Fixes sirupsen/logrus#1434 - Update stretchr/testify to v1.9.0 to resolve 2 High sev vulnerabilities#1435
Closed
abetterbuilder wants to merge 2 commits intosirupsen:masterfrom
Closed
Fixes sirupsen/logrus#1434 - Update stretchr/testify to v1.9.0 to resolve 2 High sev vulnerabilities#1435abetterbuilder wants to merge 2 commits intosirupsen:masterfrom
abetterbuilder wants to merge 2 commits intosirupsen:masterfrom
Conversation
added 2 commits
June 7, 2024 10:59
Author
|
I'm not sure where the config for the windows AppVeyor runner is to make the version of GO set to 1.18. The updates here appear to require 1.18 as the minimum version. I've updated all the CI yaml files to use 1.18 as a minimum but still erroring in the windows runner. |
Contributor
|
One do not change the minimum go version of a project just to fix a vulnerability in a remote dependency which is not even used in the project.
So this is not at all "2 high severity vulnerabilities". This PR is just FUD and completely useless. Disclaimer: I'm one Testify co-maintainer. |
Collaborator
|
This was superseded by #1460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1434